Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing notes in Lit Up's charts #134

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add missing notes in Lit Up's charts #134

wants to merge 3 commits into from

Conversation

ChillyBeanBAM
Copy link

@ChillyBeanBAM ChillyBeanBAM commented Feb 28, 2025 •
edited
Loading

This pull request adds Darnell's missing notes in Lit Up on all difficulties. Fixes FunkinCrew/Funkin#4251.

Before (section 57 only)

litupchangebefore

After (section 57 only)

litupchangeafter

@ChillyBeanBAM ChillyBeanBAM changed the title Add missing notes in Lit Up's chart Add missing notes in Lit Up's charts Feb 28, 2025
@Hundrec Hundrec added status: pending triage The bug or PR has not been reviewed yet. size: large A large pull request with more than 100 changes type: charting issue Involves the charting or placement of notes for a level. labels Feb 28, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Feb 28, 2025

Since this is a one note addition, can you manually edit the json file to include it?
Ideally, the diff would be 3 lines, one for each difficulty

@ChillyBeanBAM
Copy link
Author

ChillyBeanBAM commented Feb 28, 2025 •
edited
Loading

I'm pretty sure the added note is in there? I checked it in-game again.

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 28, 2025

Yes, I trust that this PR adds it
However, you manually exported the chart, creating thousands of line changes

What I would do it locate the timestamp of the note in your exported chart and copy it into the original lit up chart file, once for each difficulty.

@ChillyBeanBAM
Copy link
Author

Ah, I see. The problem is that I cannot locate the added note well enough.

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 28, 2025

Don't worry, I've done this with my chart PRs
I'll make a PR to your fork later today.

@Hundrec
Copy link
Collaborator

Hundrec commented Mar 2, 2025

I just found another missing note 💔

@Hundrec
Copy link
Collaborator

Hundrec commented Mar 2, 2025

I'm gonna have to do a full chart inspection before I PR to your fork
Hang in tight!

@Hundrec Hundrec mentioned this pull request Mar 2, 2025
Open
3 tasks
@ChillyBeanBAM
Copy link
Author

Yeah, this is a LOT smaller now

@Hundrec Hundrec added size: medium A medium pull request with 100 or fewer changes and removed size: large A large pull request with more than 100 changes labels Mar 3, 2025
Hundrec
Hundrec approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Feel free to link this to FunkinCrew/Funkin#4251 by using this term

"Fixes FunkinCrew/Funkin#4251"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hundrec Hundrec Hundrec approved these changes

Assignees
No one assigned
Labels
size: medium A medium pull request with 100 or fewer changes status: pending triage The bug or PR has not been reviewed yet. type: charting issue Involves the charting or placement of notes for a level.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Charting Issue: Several missing notes on Darnell's side in Lit Up
2 participants
@ChillyBeanBAM @Hundrec