[ENHANCEMENT] Make Chart Editor's volume settings carry over to PlayState #6302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
JackXson-Real
approved these changes
Oct 18, 2025
AbnormalPoof
added
type: enhancement
3 tasks
|
chud |
|
Note that this PR now requires the assets PR FunkinCrew/funkin.assets#293 to be merged as well, since that PR adds the checkbox to enable the setting |
Hundrec
added
the
topic: changes assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #6294
Description
PlayState would always make the volume of audios set to 100%. This PR adds a way to set the volumes of every audio track through PlayStateParams, as well as, you know, utilize this to make the audio settings carry over to PlayState.
Also since volumes are controlled with variables know, this might be useful for modders. LeGooey might want to take a l👀k at this.
Screenshots/Videos
chud.if.it.was.not.obscured.by.the.inst.mp4