Skip to content

[CHORE/ENHANCEMENT] Replace all instances of coolLerp with smoothLerp #5171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

charlesisfeline
Copy link
Contributor

@charlesisfeline charlesisfeline commented May 28, 2025

Linked Issues

closes #5170

Description

the title explains itself. there's like a somewhat large difference, evident by the videos below

also its basically like #3617 but simply just uses smoothLerp instead of a new function
i'm not sure if the snapping is intentional but imma just let you guys decide

btw this also gets rid of the deprecated warnings coming from coolLerp specifically

Videos

before:

2025-05-28.19-24-35.mp4

after:

2025-05-28.19-26-09.mp4

@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. and removed status: pending triage Awaiting review. labels May 28, 2025
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. labels May 28, 2025
@charlesisfeline
Copy link
Contributor Author

charlesisfeline commented May 29, 2025

oh yeah side note i was thinking of stripping off the cameraLerp function entirely in addition to coolLerp, but i quickly just decided not to since it would (potentially) break mods that use them

@Starexify
Copy link

will also "resolve" a part of my issues #4575 aswell

@charlesisfeline
Copy link
Contributor Author

superseded by #3617

@Hundrec Hundrec added status: rejected Issue did not pass review or PR cannot be approved. and removed type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. pr: haxe PR modifies game code. labels Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: medium A medium pull request with 100 or fewer changes. status: rejected Issue did not pass review or PR cannot be approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Replace all instances of coolLerp with smoothLerp
4 participants