-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Change the way strums work with Note Hits. Reorganize classes in funkin.play.notes
and Helper Functions.
#5033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
funkin.play.notes
and Helper Functions.funkin.play.notes
and Helper Functions.
I wouldn't say it's a breaking change, it still works fine with the previous scripts. (Tested with Itch.io 0.6.4 release scripts) |
It's still a breaking change due to the large amount of changes. I wouldn't be surprised if a bug was found among all those changes. |
Ehh, true |
oh god |
TODO: REDO |
Changes
A lot of classes in
funkin.play.notes
got reorganized.Strumline now have targetCharacter (to determine what character uses this strum) and downScroll (self explanatory) variables.
Some classes in
funkin.play.notes
now have _parentStrum.Rewrites how BaseCharacter handle NoteScriptEvent.
NoteSprite now have targetCharacter , thats override Strumline targetCharacter , and it can be set manually via scripts.
It should work with NoteKinds, i guess
BaseCharacter got new Helper Functions (Especially setShader, because its now used for AnimateAtlasCharacter and can be overriden for complex characters, like Nene)
Also a lot of scripts got cleaned up. (No more PlayState.instance.currentStage code in STAGE scripts, duh -_-).
Its hard to write EVERY change in this pr, so check code and write your opinions and what to change.
(the hell is that .github files)