Skip to content

Change the way strums work with Note Hits. Reorganize classes in funkin.play.notes and Helper Functions. #5033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

PurSnake
Copy link
Contributor

@PurSnake PurSnake commented May 6, 2025

Changes

  • A lot of classes infunkin.play.notes got reorganized.

  • Strumline now have targetCharacter (to determine what character uses this strum) and downScroll (self explanatory) variables.

  • Some classes in funkin.play.notes now have _parentStrum.

  • Rewrites how BaseCharacter handle NoteScriptEvent.

  • NoteSprite now have targetCharacter , thats override Strumline targetCharacter , and it can be set manually via scripts.
    It should work with NoteKinds, i guess

  • BaseCharacter got new Helper Functions (Especially setShader, because its now used for AnimateAtlasCharacter and can be overriden for complex characters, like Nene)

Also a lot of scripts got cleaned up. (No more PlayState.instance.currentStage code in STAGE scripts, duh -_-).

Its hard to write EVERY change in this pr, so check code and write your opinions and what to change.

(the hell is that .github files)

@github-actions github-actions bot added pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. labels May 6, 2025
@PurSnake PurSnake changed the title Change the way strums work with Note Hits Reorganize classes in funkin.play.notes and Helper Functions. Change the way strums work with Note Hits. Reorganize classes in funkin.play.notes and Helper Functions. May 6, 2025
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. topic: mods Related to the creation or use of mods. labels May 6, 2025
@AbnormalPoof
Copy link
Member

nearly 2000 changes...
image

@AbnormalPoof AbnormalPoof added the topic: breaking change Introduces a change that is not compatible with older versions. Existing code may need revision. label May 6, 2025
@PurSnake
Copy link
Contributor Author

PurSnake commented May 6, 2025

I wouldn't say it's a breaking change, it still works fine with the previous scripts. (Tested with Itch.io 0.6.4 release scripts)

@Starexify
Copy link

Can this PR also add better support for mods that add extra or less keys/directions to the notes ?
For example: KEY_COUNT ,SPLASHES_CAP shouldn't be final, the hold covers shouldn't be limited to 4, and maybe aswell be a variable from the strumline instead, like the KEY_COUNT.

Only if possible aswell for these functions from SongData which are forced to use 4, which mods can't modify most classes that use them:
image
image

@Lasercar
Copy link
Contributor

Lasercar commented May 7, 2025

I wouldn't say it's a breaking change, it still works fine with the previous scripts. (Tested with Itch.io 0.6.4 release scripts)

It's still a breaking change due to the large amount of changes. I wouldn't be surprised if a bug was found among all those changes.

@PurSnake
Copy link
Contributor Author

PurSnake commented May 7, 2025

It's still a breaking change due to the large amount of changes. I wouldn't be surprised if a bug was found among all those > changes.

Ehh, true

@EliteMasterEric EliteMasterEric added size: huge A huge pull request with more than 500 changes. and removed size: large A large pull request with more than 100 changes. size: huge A huge pull request with more than 500 changes. labels May 14, 2025
@PurSnake
Copy link
Contributor Author

oh god
conflicts

@PurSnake
Copy link
Contributor Author

TODO: REDO

@PurSnake PurSnake closed this Aug 21, 2025
@Hundrec Hundrec removed type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. labels Aug 21, 2025
@Hundrec Hundrec added status: rejected Issue did not pass review or PR cannot be approved. and removed topic: mods Related to the creation or use of mods. pr: haxe PR modifies game code. topic: breaking change Introduces a change that is not compatible with older versions. Existing code may need revision. labels Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: huge A huge pull request with more than 500 changes. status: rejected Issue did not pass review or PR cannot be approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants