[OPTIMIZATION] Optimize FreeplayDJ's onFinishAnim
#4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lasercar <64717068+Lasercar@users.noreply.github.com> Co-authored-by: Abnormal <86753001+AbnormalPoof@users.noreply.github.com>
github-actions
bot
added
status: pending triage
AbnormalPoof
added
type: optimization
|
The previous switch was somehow/for some reason overriding the switch cases, causing the intro end to be endlessly dispatched. Switching it all over to the state prevents that, and makes it even cleaner too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the messy if/else block in
onFinishAnimwith a switch statement. This also changes the function to checkcurrentStateinstead of the DJ's animation prefixes. This should have no effect on functionality!(Made with help by @Lasercar lol)