Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold note still pressed after pausing, removing hold and resuming game fix #4145

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Hold note still pressed after pausing, removing hold and resuming game fix #4145

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b748c20
Hold note still pressed after resuming game fix
Lasercar Feb 15, 2025
afdc7a5
removed commented out line
Lasercar Feb 15, 2025
2aa4aa4
A fix for one of the issues
Lasercar Feb 18, 2025
0e6f04a
Fixed one issue (for real this time)
Lasercar Feb 18, 2025
b1d60b3
Fixed the other issue
Lasercar Feb 18, 2025
fee02a2
This fixes sticking note thing, but...
Lasercar Feb 18, 2025
87a8eb6
Merge branch 'develop' into Hold-note-still-pressed-after-resuming-ga…
Lasercar Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions source/funkin/play/PlayState.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2162,7 +2162,12 @@ class PlayState extends MusicBeatSubState
*/
function onKeyPress(event:PreciseInputEvent):Void
{
if (isGamePaused) return;
if (isGamePaused)
{
// The player released and repressed the key, so pop the release input
inputReleaseQueue.pop();
return;
}

// Do the minimal possible work here.
inputPressQueue.push(event);
Expand All @@ -2173,7 +2178,7 @@ class PlayState extends MusicBeatSubState
*/
function onKeyRelease(event:PreciseInputEvent):Void
{
if (isGamePaused) return;
// if (isGamePaused) return;

// Do the minimal possible work here.
inputReleaseQueue.push(event);
Expand Down
Loading