-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart editor no minimum for event values fix #4110
base: develop
Are you sure you want to change the base?
Chart editor no minimum for event values fix #4110
Conversation
lol, lmao, imagine coding a input to have minimum values but just.. not setting a value?
Oh no, the bot's out of it again |
I suggest that you remove the comment where you signed your name. We don't want signatures in the source code! |
Oh, sorry. I saw a signature elsewhere in the code and thought it'd be alright. |
Thank you, though I do think the whole comment should be removed. It doesn't provide informational value to people reading the code. Also, please let us know where the other signature is so we can take a look. |
It's in the characterselect substate. I could remove it and my ones in my update of that state? #4072 |
Please don't include unrelated changes in this PR. Can you link the line to me? I'm digging around for it but will probably take a while to find it |
Thanks! Cheems is closer to the Funkin' Crew than the general community is, so that signature is acceptable. |
Could that be added into the style guide? Thanks. |
Good idea! |
The style guide already exists: https://github.com/FunkinCrew/Funkin/blob/main/docs/style-guide.md It just isn't exactly linked to or anything, you just have to find it in the docs folder. |
Oh! You meant that old thing... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good!
Does this PR close any issues? If so, link them below.
Fixes #2861
Briefly describe the issue(s) fixed.
The default events didn't have minimum values set, lol.
Include any relevant screenshots or videos.
2025-02-06.18-11-41.1.mp4
Sigh, if I had noticed that I didn't change it to the develop branch I wouldn't of deleted the branch and perma closed the previous PR out of a worry that I did something wrong on my end.