Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT + BUGFIX] Soft coding and improvement for visualizers #4063

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[ENHANCEMENT + BUGFIX] Soft coding and improvement for visualizers #4063

wants to merge 2 commits into from

Conversation

MidyGamy
Copy link
Contributor

@MidyGamy MidyGamy commented Jan 29, 2025 •
edited
Loading

This is a retake of #2994
This make visualize soft modable so nene.hxc now use it (making ABotVis.hx useless)

It also allows the visualizers to track different sounds than FlxG.sound.music, and support for cutscenes musics in Darnell and the Pico mixes of week 3.

It also fixes:

  • A-Bot is unaffected by shaders #3764
  • The visualizer sometimes render bars when there is no sound (in countdowns, cutscenes but notably at the end of songs in freeplay)
  • Abot still being bright in Blazin

@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. size: large A large pull request with more than 100 changes. pr: haxe PR modifies game code. and removed large labels Jan 29, 2025
@MidyGamy
Copy link
Contributor Author

MidyGamy commented Jan 29, 2025 •
edited
Loading

Ok wait before including it, a small issue in the web version where only the cutscene music is seen on Abot. (converting to draft)

@MidyGamy MidyGamy marked this pull request as draft January 29, 2025 23:08
@MidyGamy MidyGamy marked this pull request as ready for review January 30, 2025 01:39
@MidyGamy
Copy link
Contributor Author

MidyGamy commented Feb 2, 2025 •
edited
Loading

Wait... Shouldn't this PR have the topic: mods label?

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 2, 2025

Sure, we can do that

@Hundrec Hundrec added the topic: mods Related to the creation or use of mods. label Feb 2, 2025
@MidyGamy MidyGamy changed the title [ENHANCEMENT + BUGFIX] soft codable visualizers [ENHANCEMENT + BUGFIX] Soft codable visualizers Feb 7, 2025
@MidyGamy MidyGamy changed the title [ENHANCEMENT + BUGFIX] Soft codable visualizers [ENHANCEMENT + BUGFIX] Soft coding and improvement for visualizers Feb 7, 2025
@MidyGamy
Copy link
Contributor Author

MidyGamy commented Feb 7, 2025

A little showcase of it!
https://youtu.be/cfxkOfxTgcQ

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 7, 2025

This is actually such a cool detail!
Hope the devs like this idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. topic: mods Related to the creation or use of mods. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MidyGamy @Hundrec @AbnormalPoof