Make sound effects pause with the game #4058
Open
+39
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbnormalPoof
added
type: minor bug
NotHyper-474
force-pushed
the
bugfix/sound-pause
branch
2 times, most recently
from
4621a84 to
4a5f97b
Compare
NotHyper-474
changed the title
JackXson-Real
approved these changes
Feb 20, 2025
NotHyper-474
force-pushed
the
bugfix/sound-pause
branch
from
4a5f97b to
7268e5b
Compare
- Change behaviour to not pause on Game Over. This commit also does a required change which unintentionally fixes FunkinCrew#3600.
NotHyper-474
force-pushed
the
bugfix/sound-pause
branch
from
7268e5b to
22c0d9c
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Closes #2879 and #3600
Briefly describe the issue(s) fixed.
Scripts like
spookyMansion.hxc,phillyTrain.hxc(and Erect versions) play sound effects that don't pause with the game.Philly's train sound does get paused although that's done manually through the stage script.
This is based on how PlayState handles pausing of camera tweens.
Include any relevant screenshots or videos.
demo2.mp4