Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix the Random Button in FreeplayState not being able to switch to Erect/Nightmare songs #3838

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

KoloInDaCrib
Copy link
Contributor

Does this PR close any issues? If so, link them below.

3661 3762

Briefly describe the issue(s) fixed.

Up until this point, the Freeplay Menu's Random button was only able to cycle to default difficulties (easy, normal, hard). This PR makes it so that it checks for all the songs loaded, makes an array for all the available difficulties per character, and goes through a for-loop to fill it up. That way it also accounts for Pico not having Erect/Nightmare songs and doesn't switch to those difficulties.

Include any relevant screenshots or videos.

2024-11-06.20-48-38.mp4

@github-actions github-actions bot added pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. labels Nov 6, 2024
@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jan 17, 2025
@EliteMasterEric EliteMasterEric added status: needs revision Cannot be approved because it is awaiting some work by the contributor. type: minor bug Involves a minor bug or issue. and removed status: pending triage Awaiting review. labels Jan 17, 2025
@KoloInDaCrib
Copy link
Contributor Author

Reminder that the requested changes have been completed and this PR may be merged, if there are no further critiques

@EliteMasterEric EliteMasterEric added status: reviewing internally Under consideration and testing. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Feb 19, 2025
@EliteMasterEric EliteMasterEric self-assigned this Feb 19, 2025
@JackXson-Real
Copy link

Works good for the most part. Only problem is that when switching to erect mode, the songs don't have "erect" added onto their names until you hover over them, or if you switch to Nightmare mode.

@KoloInDaCrib
Copy link
Contributor Author

Works good for the most part. Only problem is that when switching to erect mode, the songs don't have "erect" added onto their names until you hover over them, or if you switch to Nightmare mode.

Fixed, just had to delete a line

@JackXson-Real
Copy link

Works good for the most part. Only problem is that when switching to erect mode, the songs don't have "erect" added onto their names until you hover over them, or if you switch to Nightmare mode.

Fixed, just had to delete a line

Thanks for the fix! I just tested it, and it works perfectly. I think this PR can now be merged.

Copy link
Collaborator

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: reviewing internally Under consideration and testing. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants