-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Fix the Random
Button in FreeplayState not being able to switch to Erect/Nightmare songs
#3838
base: develop
Are you sure you want to change the base?
Conversation
Reminder that the requested changes have been completed and this PR may be merged, if there are no further critiques |
Works good for the most part. Only problem is that when switching to erect mode, the songs don't have "erect" added onto their names until you hover over them, or if you switch to Nightmare mode. |
Fixed, just had to delete a line |
Thanks for the fix! I just tested it, and it works perfectly. I think this PR can now be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works
Does this PR close any issues? If so, link them below.
3661 3762
Briefly describe the issue(s) fixed.
Up until this point, the Freeplay Menu's
Random
button was only able to cycle to default difficulties (easy, normal, hard). This PR makes it so that it checks for all the songs loaded, makes an array for all the available difficulties per character, and goes through a for-loop to fill it up. That way it also accounts for Pico not having Erect/Nightmare songs and doesn't switch to those difficulties.Include any relevant screenshots or videos.
2024-11-06.20-48-38.mp4