Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Registry Macro #3694

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lemz1
Copy link
Contributor

@lemz1 lemz1 commented Oct 13, 2024

DESCRIPTION

This pr adds a macro for registries and entries. This macro adds default implementations for registries and entries.
Currently we need to implement the DefaultRegistryImpl individually for each registry because of the @:generic metadata that BaseRegistry has.
The entries dont need to individually implement DefaultEntryImpl.

@lemz1 lemz1 marked this pull request as draft October 13, 2024 17:45
@github-actions github-actions bot added size: large A large pull request with more than 100 changes. pr: haxe PR modifies game code. labels Oct 13, 2024
@lemz1 lemz1 force-pushed the feature/registry-macro branch from cf69794 to c25e09d Compare October 21, 2024 18:09
@lemz1 lemz1 force-pushed the feature/registry-macro branch 2 times, most recently from d3fbf94 to 488ba73 Compare November 7, 2024 16:17
@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jan 17, 2025
@lemz1 lemz1 force-pushed the feature/registry-macro branch from b10fc77 to b62924e Compare January 19, 2025 13:15
@lemz1 lemz1 marked this pull request as ready for review January 19, 2025 13:15
@Hundrec Hundrec added the type: enhancement Involves an enhancement or new feature. label Jan 22, 2025
@lemz1 lemz1 force-pushed the feature/registry-macro branch 2 times, most recently from b7aab5a to 8fa33a5 Compare January 23, 2025 22:15
@lemz1 lemz1 force-pushed the feature/registry-macro branch from 8fa33a5 to 9fc5aec Compare February 1, 2025 16:32
@github-actions github-actions bot added large and removed large labels Feb 1, 2025
@lemz1 lemz1 force-pushed the feature/registry-macro branch from 9fc5aec to 6b42b40 Compare February 18, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants