Working input offset #3234
Open
Working input offset #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hundrec
added
type: major bug
|
This PR appears to have merge conflicts. Please fix them! |
AbnormalPoof
added
status: needs revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
#2382
Briefly describe the issue(s) fixed.
The input offset value currently doesn't adjust the hit windows for the player.
Include any relevant screenshots or videos.
Here are two videos. The first is on the current build of the game, and the second is on a build with this fix implemented. The offset in both is 800ms. You can see that in the first video, the hit window occurs well before the notes reach the strumline, whereas in the second video the hit window lines up with when the notes hit the strumline.
input_offset_broken.mp4
input_offset_fixed.mp4
The event animations (like the BF "hey") still don't adjust for offset, but I'm not sure how to go about fixing that
(Also my IDE added a bunch of whitespace to some of the comments for some reason, please disregard)