Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Implement a better Strumline Note Confirm Animation #2864

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[ENHANCEMENT] Implement a better Strumline Note Confirm Animation #2864

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41d76b0
Implement a better strumline note confirm animation
gamerbross Jun 20, 2024
9a5f4da
Fix player double note premature static animation
gamerbross Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix player double note premature static animation
  • Loading branch information
@gamerbross
gamerbross committed Jun 20, 2024
commit 9a5f4da48d9ceda19d7dea18acb792d5f3ecfb29
2 changes: 1 addition & 1 deletion source/funkin/play/notes/StrumlineNote.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class StrumlineNote extends FlxSprite
{
this.active = true;
this.playAnimation('confirm', true);
if (!isPlayer) confirmHoldTimer = 0;
confirmHoldTimer = isPlayer ? -1 : 0;
}

public function isConfirm():Bool
Expand Down
Loading