Clean up a part of ChartEditorThemeHandler, fixing a bug with it. #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fire |
tposejank
approved these changes
Jun 20, 2024
EliteMasterEric
added
status: pending triage
AbnormalPoof
approved these changes
Jun 20, 2024
anysad
approved these changes
Jun 23, 2024
EliteMasterEric
added
the
size: medium
Beat and step ticks now appear fully on 5/4, 6/4 and 9/8 time signatures.
ninjamuffin99
force-pushed
the
charting-theme-fixes
branch
from
01e9661 to
ee366c1
Compare
Hundrec
added
status: accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was Eric smoking when he wrote this code??? Anyway, this cleans up some code in the Chart Editor Theme Handler, fixing too few beat/step tick lines appearing on 5/4, 6/4 and 9/8 time signatures.