Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX?] SaveData using a player 2 controls instead of player1 controls #2481

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

gamerbross
Copy link
Contributor

SaveData was using player2 controls because of an incorrect check (assumed playerId 0 is for player1, so always used player2 instead).

Warning

This change will wipe user's controls.
Could be fixed with some kind of migration of the save data, maybe increasing savedata version and moving player2 controls to player1 controls, and emptying player2 controls

@Matriculaso
Copy link

Esto es bien mierda pq no
tiene var singSong = "Douh homero";

@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jun 17, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jul 10, 2024
@EliteMasterEric EliteMasterEric added type: minor bug Involves a minor bug or issue. status: reviewing internally Under consideration and testing. size: medium A medium pull request with 100 or fewer changes. and removed status: pending triage Awaiting review. labels Jul 10, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 00:59
@EliteMasterEric EliteMasterEric added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: reviewing internally Under consideration and testing. labels Jul 12, 2024
@Hundrec Hundrec added the pr: haxe PR modifies game code. label Jan 22, 2025
@EliteMasterEric EliteMasterEric removed their assignment Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: needs revision Cannot be approved because it is awaiting some work by the contributor. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants