Bug Report: Event sprites in editor not moving properly when dragging

[amyspark-ng]

Issue Checklist

• I have read the Contributing Guide
• I have checked the Issues/Discussions pages to see if my issue has already been reported
• I have properly titled my issue

Platform

Itch.io (Downloadable Build) - Windows

Browser

None

Version

0.5.3

Description (include any images, videos, errors, or crash logs)

When dragging mixed items in the editor (notes and events) the events might not move accordingly to the notes, it seems to only be an issue in the first 2 beats for some reason? don't really know what could be causing it

Also only happens when you've clicked the notes to drag them, if you click the event it will work properly

2025-02-19_11-49-30.mp4

Steps to Reproduce

1. Open the editor
2. Select both notes and events
3. Click one of the notes and try to drag them
4. The event won't be moved properly

[Hundrec]

Now that's plain weird.

[Lasercar]

Thought I might help you find the spot for fixing the new issue you noticed:

Funkin/source/funkin/ui/debug/charting/ChartEditorState.hx

Lines 3801 to 3804 in 5054c58

	if (isEventSelected(eventSprite.eventData))
	{
	// Determine if the note is being dragged and offset the position accordingly.
	if (dragTargetCurrentStep > 0 || dragTargetCurrentColumn > 0)

For comparison:

Funkin/source/funkin/ui/debug/charting/ChartEditorState.hx

Lines 3741 to 3744 in 5054c58

	if (isNoteSelected(noteSprite.noteData))
	{
	// Determine if the note is being dragged and offset the vertical position accordingly.
	if (dragTargetCurrentStep != 0.0)

It took me a few minutes to spot the issue, I didn't realise how simple of a fix it was.

I want to see if you can spot it too. If you still can't, I'll give you a hint.

[amyspark-ng]

is the issue that events check for column while notes don't? that's kinda weird

If not the fact that events use '>' and notes use '!=' that could also be it

I'll take a look at it later and see if i can fix it