Bug Report: "Total notes" on the results screen does not reflect the actual number of notes in a song.

[NewCs386148]

Issue Checklist

• I have properly named the issue
• I have checked the issues/discussions pages to see if the issue has been previously reported

What platform are you using?

Newgrounds (Web)

If you are playing on a browser, which one are you using?

Microsoft Edge

Version

0.4.1

Context (Provide images, videos, etc.)

I played 2hot and ended up getting 89% despite my "sicks" and "goods" totaling to about 91% of the total notes. I added up the numbers of each category, and it turns out that somehow there are 17 more notes there than there are in the total notes section of the screen.

Score:

Math:

After playing the song again, the "total notes" was an entirely different number! However, adding up the numbers of each individual accuracy category still adds up to 585, and the % cleared still uses 585 as the number of notes in the song to calculate its percentage.

Steps to reproduce (or crash logs, errors, etc.)

Play any song in the game and don't get a full combo. In this example here, I played the tutorial on normal and missed the whole first turn.

[Hundrec]

This is a really strange bug that seems to only affect the displayed value for "Total Notes".

From your report, I'm getting that none of the calculations related to the total number of notes were affected, right?

[Keoiki]

Based on the 3rd picture, you'd think Total Notes means the total notes you HIT in the song, not total notes in the song in general.

But putting together the numbers, excluding misses, gives 566 in the first picture (2 lower than what Total Notes says) and 561 in the second picture (1 lower than what Total Notes says)

What gives?

[NewCs386148]

From your report, I'm getting that none of the calculations related to the total number of notes were affected, right?

Yes. Despite the displayed number being wrong, it still calculates percentages with the real number of total notes (which seems to be the number of all five accuracy categories added up).

[Hundrec]

Maybe there's a rare chance for the game to skip counting a hit note if there's a lagspike?

[NewCs386148]

Possibly. I find it strange that the game seems to calculate total notes while you're playing the song instead of deriving that value from the chart itself.

[Keoiki]

OK This isn't even a bug, it's like that on purpose as that number shows the totalNotesHit:

Funkin/source/funkin/play/ResultState.hx

Line 368 in 9b483de

* NOTE: We display how many notes were HIT, not how many notes there were in total.

Funkin/source/funkin/play/ResultState.hx

Line 371 in 9b483de

var totalHit:TallyCounter = new TallyCounter(375, hStuf * 3, params.scoreData.tallies.totalNotesHit);

But I still don't understand why either: the total number is wrong or the sick/good/bad/shit numbers are wrong (based on what I said in my previous comment)

[Hundrec]

So that leaves the off-by-a-few issue as well as a need for clarification that it's "Total Notes Hit" rather than "Total Notes in the song"

[NewCs386148]

a need for clarification that it's "Total Notes Hit" rather than "Total Notes in the song"

They could make it say something like "Total Notes: [Total notes hit]/[Total notes in song]" instead of "Total Notes: [Total notes hit]". They'd have to make it a scrolling textbox or something to keep it off the yellow background, but it would properly communicate both values.

[amyspark-ng]

true! this is pretty weird

[Lasercar]

Yeah, total notes = total notes hit.

[amyspark-ng]

isn't that weird?