Bug Report: Hold Notes Still being pressed after pasuing and realeasing the pressed key

[MafiaPlay2]

Please check for duplicates or similar issues, as well performing simple troubleshooting steps (such as clearing cookies, clearing AppData, trying another browser) before submitting an issue.

If you are playing the game in a browser, what site are you playing it from?

• Newgrounds
• Itch.io? Specify below
• • Windows
• • Mac
• • Linux

If you are playing the game in a browser, what browser are you using?

• Google Chrome (or chomium based like Brave, vivaldi, MS Edge)
• Firefox
• Safari

What version of the game are you using? Look in the bottom left corner of the main menu. (ex: 0.2.7, 0.2.1, shit like that)

0.3.0 Prototype

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.

Pause while holding a hold note and after unpausing it will finish the hold on its own (not really sure how to explain it lol)

Please describe your issue. Provide extensive detail and images if possible.

0501.mp4

If you're game is FROZEN and you're playing a web version, press F12 to open up browser dev window, and go to console, and copy-paste whatever red error you're getting

[amyspark-ng]

I don't know about this, i think this is cool.....

[Hundrec]

Still happens in 0.5.0

[amyspark-ng]

i still think it's cool...

[Lasercar]

Is this really a bug though?

I think most people when resuming a song from the pause menu don't think 'hey, maybe I should preemptively hold that note again'

If a dev comments and says that this is a bug, then I'll have a go at fixing it.

Wait, nvm, I see an issue - it actually continues to hold after the note is finished?

Hmm, it seems to be an issue with the latency state / precise input manager?

Looks like the issue is here:

Funkin/source/funkin/play/PlayState.hx

Line 2176 in 6466b88

if (isGamePaused) return;

Commenting out the line does fix the issue, but causes a different one where you now have to keep holding the note while in the pause state - if you stop holding it and then hold it again before continuing it'll stop holding the note, despite the fact that you pressed and held the note before resuming.

I freaking fixed the above thing! I'm a genius!

[Lasercar]

i still think it's cool...

And I still think it needs to be fixed!
#4145

(I totally didn't want to fix this issue just because I could say this afterwards, nuh-uh!)