Skip to content

refactor: update AddFunc.vue to composition API#91

Merged
Akhil-Yuan merged 104 commits intoFunctionStream:mainfrom
GiorunoGiovanna:main
Oct 8, 2021
Merged

refactor: update AddFunc.vue to composition API#91
Akhil-Yuan merged 104 commits intoFunctionStream:mainfrom
GiorunoGiovanna:main

Conversation

@GiorunoGiovanna
Copy link
Contributor

No description provided.

GiorunoGiovanna and others added 30 commits June 2, 2021 22:12
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
GiorunoGiovanna and others added 15 commits August 1, 2021 22:36
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
@RobertIndie RobertIndie requested a review from Akhil-Yuan October 2, 2021 13:40
@RobertIndie RobertIndie added this to the 0.2.0 milestone Oct 2, 2021
@Akhil-Yuan
Copy link
Contributor

Akhil-Yuan commented Oct 2, 2021

Thank you for PR, but there are still some problems.

First, I think the style needs some modifications. Several input boxes have inconsistent widths that make them look strange. You can also adjust the margins between text and input boxes.

Second, you can write together code that handles the same logic in the Vue file, which will makes the code more readable. This is also the reason why we use composition API instead of option API.

Copy link
Contributor

@Akhil-Yuan Akhil-Yuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend creating a new branch to manage commits each time you develop a PR, and synchronizing the main branch of your own repository in a timely manner to prevent redundant commits like the one in this PR.

But for now, you don't have to change the branch in this PR. You can follow the way above for future development.

@GiorunoGiovanna
Copy link
Contributor Author

I recommend creating a new branch to manage commits each time you develop a PR, and synchronizing the main branch of your own repository in a timely manner to prevent redundant commits like the one in this PR.

But for now, you don't have to change the branch in this PR. You can follow the way above for future development.

OK, thank you for your advice

Copy link
Contributor

@Akhil-Yuan Akhil-Yuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error will be reported on the console when resetting the form.

@Akhil-Yuan Akhil-Yuan self-requested a review October 8, 2021 02:21
@Akhil-Yuan Akhil-Yuan merged commit 0555250 into FunctionStream:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants