Skip to content

[CI] Add github actions: eslint-check#53

Merged
RobertIndie merged 14 commits intoFunctionStream:mainfrom
winnd:add-github-workflows
Jun 26, 2021
Merged

[CI] Add github actions: eslint-check#53
RobertIndie merged 14 commits intoFunctionStream:mainfrom
winnd:add-github-workflows

Conversation

@winnd
Copy link
Contributor

@winnd winnd commented Jun 26, 2021

  1. [UI] Eslint: Fix eslint warnings and errors before use github-actions-eslint-check
  2. [CI] Add github actions: eslint-check

@winnd
Copy link
Contributor Author

winnd commented Jun 26, 2021

It seems still has some steps with how to set github actions run automatically.↓↓

https://stackoverflow.com/questions/58654530/how-to-reject-a-pull-request-if-tests-are-failed-github-actions

@winnd
Copy link
Contributor Author

winnd commented Jun 26, 2021

I will do some optimization rather than npm install

@RobertIndie RobertIndie added this to the 0.2.0 milestone Jun 26, 2021
winnd added 2 commits June 26, 2021 18:45
[CI] remove --save-dev
replace npm install to yarn install
Copy link
Contributor

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobertIndie RobertIndie merged commit d8b6f67 into FunctionStream:main Jun 26, 2021
@RobertIndie RobertIndie mentioned this pull request Jun 26, 2021
@RobertIndie RobertIndie linked an issue Jun 26, 2021 that may be closed by this pull request
@winnd winnd deleted the add-github-workflows branch September 8, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Eslint check

2 participants