Css globs #81
Merged
Css globs #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnanigans
reviewed
Apr 23, 2018
| cssOptions = cssOptions.map(option => { | ||
| return typeof option === 'string' ? glob.sync(option) : option | ||
| }) | ||
| cssOptions = [].concat.apply([], cssOptions) |
There was a problem hiding this comment.
could we maybe use the native Array.prototype.flatten() method instead of that hack?
if the depth is only 1 this should work:
...
}).flatten()There was a problem hiding this comment.
@jsnanigans I was trying that originally, but it's not in node yet...
There was a problem hiding this comment.
huh strange but OK then
There was a problem hiding this comment.
yes, the proposal is still ongoing https://developers.google.com/web/updates/2018/03/smooshgate
There was a problem hiding this comment.
I really hope they don't call it smoosh
|
@Ffloriel could you review and merge this please? |
|
Thanks for the issue and PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix #80
Types of changes
Checklist