Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #166 #167

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Fix issue #166 #167

merged 1 commit into from
Feb 18, 2019

Conversation

ThisNameWasTaken
Copy link
Contributor

Proposed changes

I am changing the separtor for the words inside the animation prop from spaces to spaces and comas. So that something like spin 300ms linear infinite forwards,scale 300ms linear infinite alternate becomes

[  "spin", "300ms", "linear", "infinite", "forwards", "scale", "300ms", "linear", "infinite", "alternate" ]

rather than

[  "spin", "300ms", "linear", "infinite", "forwards,scale", "300ms", "linear", "infinite", "alternate" ]

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ffloriel Ffloriel self-requested a review February 18, 2019 13:08
@Ffloriel
Copy link
Member

Thanks a lot for the fix, I'll create a new release with the fix this week.

@Ffloriel Ffloriel merged commit cde0071 into FullHuman:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants