Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios-build-number): filter build number tag by build_type #49

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

robdeans
Copy link

When fetching the build number on iOS, we are neglecting to pass the build_type param which if provided will filter the tags based on environment.

Currently: with no filter provided, the most recent build number is fetched and incremented regardless of the environment.

**Start**
Production/Snapshot-100
...
Snapshot-101
Snapshot-102
Production-103
Snapshot-104
Production-105

Expected behavior: build numbers should increment based on their respective environments

**Start**
Production/Snapshot-100
...
Snapshot-101
Snapshot-102
Production-101
Snapshot-103
Production-102

@robdeans robdeans added bug Something isn't working iOS Relates to iOS labels Oct 23, 2023
@robdeans robdeans requested a review from a team October 23, 2023 18:59
Copy link

@vinaykharb vinaykharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@robdeans robdeans merged commit 3b93a61 into main Oct 24, 2023
1 check passed
@robdeans robdeans deleted the fix/build-number branch October 24, 2023 16:49
@robdeans robdeans restored the fix/build-number branch October 24, 2023 16:49
@robdeans
Copy link
Author

Keeping this branch until the next release so it doesn't break Eater's CI

@robdeans robdeans deleted the fix/build-number branch October 24, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iOS Relates to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants