-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fly-io): Added fly.io template files #475
Conversation
… and Github actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible to use the existing docker files?
{{cookiecutter.github_repository}}/compose/fly/django/celery/beat/start
Outdated
Show resolved
Hide resolved
{{cookiecutter.github_repository}}/compose/fly/django/celery/flower/start
Outdated
Show resolved
Hide resolved
{{cookiecutter.github_repository}}/compose/fly/django/celery/worker/start
Outdated
Show resolved
Hide resolved
@CuriousLearner @sun337 @saurabh-fueled are we wanting to keep a Fly.io template in this, or should this be closed? |
I think this is a good addition since we removed Heroku sometime ago. |
Oops! Pardon me. Heroku is still there. We can add fly.io similar to how Heroku is added. However, I think we need to settle down on either poetry or requirements.txt, otherwise, we are creating a matrix of options that will be difficult to maintain. Please let me know your thoughts. |
We go with poetry. |
Added fly.io template files for a deployable Dockerfile and Github actions.
Spin up a hosted development environment fast.
Adds fly.io as an optional deployment destination.
The local and dev Dockerfiles do not have the same configuration that Fly.io expects. When deploying the
dev
Dockerfile, Fly.io deploys hang due to theentrypoint
script running the gunicorn command which never exits. Therefore a separatecompose/fly
folder has the necessary changes to pass the build process.Addresses #466