Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fly-io): Added fly.io template files #475

Merged
merged 3 commits into from
Dec 20, 2023
Merged

feat(fly-io): Added fly.io template files #475

merged 3 commits into from
Dec 20, 2023

Conversation

john-fueled
Copy link
Contributor

@john-fueled john-fueled commented May 5, 2023

Added fly.io template files for a deployable Dockerfile and Github actions.

Why was this change necessary?

Spin up a hosted development environment fast.

How does it address the problem?

Adds fly.io as an optional deployment destination.

Are there any side effects?

The local and dev Dockerfiles do not have the same configuration that Fly.io expects. When deploying the dev Dockerfile, Fly.io deploys hang due to the entrypoint script running the gunicorn command which never exits. Therefore a separate compose/fly folder has the necessary changes to pass the build process.

Addresses #466

Copy link
Member

@theskumar theskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasparszarinovs
Copy link

@CuriousLearner @sun337 @saurabh-fueled are we wanting to keep a Fly.io template in this, or should this be closed?
I personally think Fly.io is probably not a bad option for dev phase deploiyments.

@CuriousLearner
Copy link
Contributor

I think this is a good addition since we removed Heroku sometime ago.

@CuriousLearner
Copy link
Contributor

Oops! Pardon me. Heroku is still there. We can add fly.io similar to how Heroku is added.

However, I think we need to settle down on either poetry or requirements.txt, otherwise, we are creating a matrix of options that will be difficult to maintain. Please let me know your thoughts.

@theskumar
Copy link
Member

We go with poetry.

@theskumar theskumar merged commit 23840aa into main Dec 20, 2023
3 checks passed
@theskumar theskumar deleted the feat/deploy-fly branch December 20, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants