-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Move import name resolution to Root #5916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for afc32deClick to view benchmark
|
Benchmark for 046555aClick to view benchmark
|
8 tasks
IGI-111
approved these changes
Apr 30, 2024
tritao
approved these changes
Apr 30, 2024
Benchmark for 50dbfdeClick to view benchmark
|
Benchmark for 3ec3858Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5913 .
Name resolution for imports and top-level items in module currently happens at the module level, in part by traversing the submodules of the current module.
This PR moves name resolution to the root of the module structure.
This refactoring is needed to enable fixes to the following issues:
Module
s and makeModule::name
mandatory #5498 : The modules from which items are imported are currently introduced as submodules to the importing module (in addition to their absolute location in the module hierarchy). To remove those submodules the name resolution algorithm needs access to the full module hierarchy, which it can get by having access to the root of the hierarchy.Checklist
Breaking*
orNew Feature
labels where relevant.