-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing and fixing CEI pattern analysis (follow up for #3168) #3356
Merged
Commits on Nov 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d71f562 - Browse repository at this point
Copy the full SHA d71f562View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53b6415 - Browse repository at this point
Copy the full SHA 53b6415View commit details
Commits on Nov 13, 2022
-
test: CEI pattern violation in function application
The function's argument is a code block with interaction, the function does storage write.
Configuration menu - View commit details
-
Copy full SHA for 1562239 - Browse repository at this point
Copy the full SHA 1562239View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9e7578 - Browse repository at this point
Copy the full SHA e9e7578View commit details -
Configuration menu - View commit details
-
Copy full SHA for 332a240 - Browse repository at this point
Copy the full SHA 332a240View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9949d57 - Browse repository at this point
Copy the full SHA 9949d57View commit details -
test: CEI pattern violation in
if
statementInteraction in the condition, storage in a branch
Configuration menu - View commit details
-
Copy full SHA for 6d89cad - Browse repository at this point
Copy the full SHA 6d89cadView commit details -
Configuration menu - View commit details
-
Copy full SHA for e01394e - Browse repository at this point
Copy the full SHA e01394eView commit details -
test: CEI pattern violation in while loops
Fixed pattern violation detection in the cases where there is first storage modification and only then an external contract call, because on the next iteration it will be storage modification again close #3342
Configuration menu - View commit details
-
Copy full SHA for 1c96bb7 - Browse repository at this point
Copy the full SHA 1c96bb7View commit details
Commits on Nov 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c335428 - Browse repository at this point
Copy the full SHA c335428View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.