Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use raw_ptr methods in message.sw #3139

Merged
merged 5 commits into from
Oct 26, 2022
Merged

Use raw_ptr methods in message.sw #3139

merged 5 commits into from
Oct 26, 2022

Conversation

AlicanC
Copy link
Contributor

@AlicanC AlicanC commented Oct 25, 2022

Following up on this: #2828 (comment)

However, the changes you had to send_message seemed a bit buggy. send_message is only tested in token_ops currently so no surprise that Ci was passing. Regardless, I reverted the implementation of send_message to how it was, for the most part. We can iterate on that in the future.

@mohammadfawaz, it seems like raw_ptr::read() didn't behave like I assumed it would. Still made use of ::add() and ::write() to pack alloc()s together and get rid of one __addr_of(), but the other one stayed.

@AlicanC AlicanC self-assigned this Oct 25, 2022
@AlicanC AlicanC added the lib: std Standard library label Oct 25, 2022
Copy link
Contributor

@mohammadfawaz mohammadfawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, much better. Thanks!

@AlicanC AlicanC marked this pull request as ready for review October 25, 2022 16:01
@AlicanC AlicanC requested a review from otrho as a code owner October 25, 2022 16:01
@AlicanC AlicanC requested a review from a team October 25, 2022 16:01
@AlicanC AlicanC enabled auto-merge (squash) October 26, 2022 13:05
@AlicanC AlicanC merged commit f63973a into master Oct 26, 2022
@AlicanC AlicanC deleted the jc/raw-ptr-followup branch October 26, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib: std Standard library
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants