-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ASM control flow to/from addresses which don't fit in immediate offsets. #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… immediate offsets. - Introduce a new control flow op `LoadLabel` which reads an address from the data section. - Convert `JI`, `JNZI`, `JNEI` and `MoveAddress` to use `LoadLabel` and `JMP` or `JNE` when required. - Introduce a `BLOB` instruction which is for testing purposes only, and efficiently & conveniently inserts a raft of `NOOP`s into the binary.
otrho
added
enhancement
New feature or request
compiler: codegen
Everything to do with IR->ASM, register allocation, etc.
labels
Oct 24, 2022
mohammadfawaz
previously approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🚀
sezna
previously approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
mohammadfawaz
approved these changes
Oct 24, 2022
sezna
approved these changes
Oct 24, 2022
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler: codegen
Everything to do with IR->ASM, register allocation, etc.
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadLabel
which reads an address from the data section.JI
,JNZI
,JNEI
andMoveAddress
to useLoadLabel
andJMP
orJNE
when required.BLOB
instruction which is for testing purposes only, and efficiently & conveniently inserts a raft ofNOOP
s into the binary.Closes #2385.