Refactor forc init + add forc new #1669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 �[0m�[32mSuccessfully created contract: sway �[0m To compile, use `forc build`, and to run tests use `forc test` ---- Read the Docs: - Sway Book: https://fuellabs.github.io/sway/latest - Rust SDK Book: https://fuellabs.github.io/fuels-rs/latest - TypeScript SDK: https://github.com/FuelLabs/fuels-ts Join the Community: - Follow us @swaylang: https://twitter.com/SwayLang - Ask questions in dev-chat on Discord: https://discord.com/invite/xfpK4Pe Report Bugs: - Sway Issues: https://github.com/FuelLabs/sway/issues/new add
ra0x3
added
forc
breaking
adlerjohn
reviewed
May 26, 2022
ra0x3
force-pushed
the
rashad/1638-forc-init-forc-new
branch
from
f742e9e
to
4a1cdac
Compare
mitchmindtree
suggested changes
May 27, 2022
There was a problem hiding this comment.
Great to see this happening!
I think we can remove a lot of duplicated code/logic between forc new and forc init.
We can think of
forc new <path>
very roughly as a tiny short-hand wrapper around:
mkdir -p <path>
forc init --path <path>
Let's refactor the forc new logic here to take advantage of the forc init functionality to make this easier to maintain and keep behaviour consistent.
|
Converting to draft both because will a few comments to address, and so as not to merge it during the hackathon by accident since it's a breaking change. |
added 2 commits
May 27, 2022 13:56
mitchmindtree
suggested changes
May 28, 2022
mitchmindtree
suggested changes
Jun 1, 2022
JoshuaBatty
previously approved these changes
Jun 2, 2022
mitchmindtree
suggested changes
Jun 3, 2022
mitchmindtree
suggested changes
Jun 6, 2022
ra0x3
force-pushed
the
rashad/1638-forc-init-forc-new
branch
from
d1cbb82
to
b80ffa1
Compare
adlerjohn
reviewed
Jun 16, 2022
added 2 commits
June 29, 2022 13:00
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
forc inittoforc new, and updatesforc initfunctionality to be more similar tocargo initTesting steps
forc initproject with combinations of the different flagsRead the Docs:
Join the Community:
Report Bugs: