-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build-and-publish-forc-binary CI job #1513
Conversation
4593f43
to
51e9164
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! This only uploads forc
, right? We need all forc*
binaries though, including forc-fmt
, forc-lsp
, etc.
@adlerjohn Whoops, thought those binaries would be made in separate PRs. I can add those as well in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this new change tested in the test repo? If not, I would like to see an example of it passing.
@adlerjohn Yea it was. I tested it last night. I cleaned up all the releases/tags in the test repo after I was finished but can go run it again |
@adlerjohn Feel free to checkout the assets over at https://github.com/FuelLabs/ci-dummy-test/releases/tag/v0.12.0 |
96ae6be
to
1c32ee1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. This was the biggest blocker to having swayup
/forcup
! I'll defer to @JoshuaBatty and @mitchmindtree for final review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nit I swear 😂
fa450f2
to
e37c212
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @ra0x3, looking good to me!
uses: actions-rs/cargo@v1 | ||
with: | ||
command: install | ||
args: --profile=release --path ./forc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
args: --profile=release --path ./forc | |
args: --path ./forc |
--release
is the default profile for the cargo install
command (mentioned here) so could be removed from here and the following install
invocations for the plugins, but I don't mind leaving it in for clarity - up to you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
build-and-publish-forc-binary
CI job that uploadsforc
binaries for different architectures to a release, when the release is publishedTesting Steps
To test a binary
darwin_amd64
)You can view these test binaries over at https://github.com/FuelLabs/ci-dummy-test/releases/tag/v0.12.0