Re-introduce the single arg contract call optimisation for IR. #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otrho
force-pushed
the
otrho/fix_ir_contract_call_args
branch
from
f7103c1
to
3bedde4
Compare
otrho
added
bug
otrho
force-pushed
the
otrho/fix_ir_contract_call_args
branch
from
3bedde4
to
ae3142e
Compare
|
Argh, the E2E test is failing, I assume because the code expects the single arg optimisation but the IR doesn't compile them. But I may be wrong... it's getting late for me, I'll revisit tomorrow. |
nfurfaro
reviewed
Apr 15, 2022
otrho
force-pushed
the
otrho/fix_ir_contract_call_args
branch
2 times, most recently
from
86e45b6
to
da47b75
Compare
Re-introduce the special case where if there's a single argument to a function call it is embedded directly in the call frame rather than being a pointer to the args elsewhere.
otrho
force-pushed
the
otrho/fix_ir_contract_call_args
branch
from
da47b75
to
e5064f8
Compare
mohammadfawaz
approved these changes
Apr 17, 2022
sezna
reviewed
Apr 18, 2022
Comment on lines
+839
to
+840
| // the unnecessary copying eventually, though it feels like we're jumping | ||
| // through a bunch of hoops here (employing the single arg optimisation) for |
There was a problem hiding this comment.
@otrho is letting his political opinions leak into the code again
There was a problem hiding this comment.
It's just an observation. No judgement. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-introduce the special case where if there's a single argument to a function call it is embedded directly in the call frame rather than being a pointer to the args elsewhere.
This will fix for errors we currently get when trying to call some contract from the SDK.
I'm halfway through working out what else needs to be fixed for contract calls + SDK but I've been on the road a bit and haven't had time. So I thought I'd submit this PR now in case it's blocking anyone.
Closes #1138.