Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial setup and testing for the MidenVM backend #3695

Open
mohammadfawaz opened this issue Jan 5, 2023 · 0 comments
Open

Initial setup and testing for the MidenVM backend #3695

mohammadfawaz opened this issue Jan 5, 2023 · 0 comments
Labels
MidenVM Issues related to the MidenVM backend implementation testing General testing

Comments

@mohammadfawaz
Copy link
Contributor

The E2E tests directory currently spins up a FuelVM instance for every Sway program and runs the program on that instance. We could do something similar with the MidenVM, especially that MidenVM is written in Rust.

This task includes studying harness.rs and mod.rs and figure out how to do the same for MidenVM. We can figure out the ideal folder structure once we have an initial implementation.

https://github.com/FuelLabs/sway/pull/3685/files also starts some of that work for the EVM backend.
@mohammadfawaz mohammadfawaz added testing General testing MidenVM Issues related to the MidenVM backend implementation labels Jan 5, 2023
@mohammadfawaz mohammadfawaz mentioned this issue Jan 5, 2023
Open
@p0ry-g0n p0ry-g0n mentioned this issue Feb 23, 2023
Merged
7 tasks
tritao added a commit that referenced this issue Feb 27, 2023
@p0ry-g0n @sezna
@tritao @JoshuaBatty
Set up infrastructure for MidenVM compilation mode (#4173)
e8dee04 
## Description
Hello! I am beginning work on the MidenVM backend.

This PR closes: #3697 #3696 #3695 and #3694.

I have created a new trivial test under `should_pass/midenvm`. Ideally,
eventually we will be able to run the relevant section of the main test
suite via `supported_targets`. I will seek to do that after more
compilation is built out. For now, this is a POC test that directly
addresses #3696.

Note that the Miden VM ASM builder will be modified heavily going
forward, and is not in a final state. I am submitting this in the spirit
of early feedback, and look forward to the reviews, but note that this
code path should not be considered "production ready" (note the `todo`
panics).

## Checklist

- [x] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: Alex Hansen <alex@alex-hansen.com>
Co-authored-by: João Matos <joao@tritao.eu>
Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MidenVM Issues related to the MidenVM backend implementation testing General testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mohammadfawaz