Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate reentrancy guard to sway-libs #3217

Closed
adlerjohn opened this issue Oct 31, 2022 · 0 comments · Fixed by #3698
Closed

Migrate reentrancy guard to sway-libs #3217

adlerjohn opened this issue Oct 31, 2022 · 0 comments · Fixed by #3698
Assignees
@jtriley-eth
Labels
lib: std Standard library

Comments

@adlerjohn
Copy link
Contributor

In light of #10 being resolved (soon), migrate the reentrancy guard out of the stdlib and into https://github.com/FuelLabs/sway-libs since its use should not be standard.
@adlerjohn adlerjohn added the lib: std Standard library label Oct 31, 2022
This was referenced Jan 4, 2023
Closed
Merged
@jtriley-eth jtriley-eth mentioned this issue Jan 23, 2023
Merged
bitzoic added a commit to FuelLabs/sway-libs that referenced this issue Feb 1, 2023
@jtriley-eth @nfurfaro @bitzoic
migrate reentrancy to new directory structure (#83)
4ca20a0 
## Reentrancy Library Migration

## Changes

The following changes have been made:

- Reentrancy library has been migrated from the std library to sway-libs
- Reentrancy tests have been migrated
- A new directory, `test_artifacts` has been introduced for
multi-contract tests
- The build script (`.github/scripts/build.sh`) has been modified to
build `test_artifacts`

## Notes

- It may be worth reviewing the rest of the ci pipeline to ensure the
new directory is handled properly

## Related Issues

Part 1 of [Issue 3217 in
Fuellabs/sway](FuelLabs/sway#3217)

---------

Co-authored-by: Nick Furfaro <nfurfaro33@gmail.com>
Co-authored-by: Cameron Carstens <54727135+bitzoic@users.noreply.github.com>
mohammadfawaz added a commit that referenced this issue Feb 7, 2023
@jtriley-eth @mohammadfawaz
Remove reentrancy library (#3698)
b80283f 
## Overview

Closes #3217, migrates the reentrancy library to Sway-libs.

> Notice: Awaiting merge and version bump from Sway-libs ([relevant pull
request](FuelLabs/sway-libs#70)).

## Changes

- remove reentrancy library
- remove reentrancy tests
- modifies documentation to point to new reentrancy guard url
- modifies imports of `std::reentrancy::` to `sway_libs::reentrancy`

---------

Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtriley-eth jtriley-eth

Labels
lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove reentrancy library FuelLabs/sway
2 participants
@adlerjohn @jtriley-eth