UFP64 #31
UFP64 #31
Conversation
bitzoic
added
New Feature
|
Just for posterity, could you fill out the PR description with the change? |
rostyslavtyshko
requested review from
bitzoic and
mohammadfawaz
and removed request for
simonr0204
There was a problem hiding this comment.
Mostly just cleaning up some comments.
Are you able to add this to the test harness? The tests exist but none of them are called. You can follow this example of how the i8 tests are run here. Here is the full PR that added all the tests: #45
Are you also able to add a README and a SPECIFICATION so that other developers know how to use the library?
… into rostyslavtyshko/ufp64
There was a problem hiding this comment.
A few comments on the documentation but overall looks great!! This should be the last of the comments and it is ready for merge.
I also noticed it wasn't added to the source README. Can you add it to the libraries list?
Still waiting on adding the library to the tests as described by the last review.
Type of change
Changes
The following changes have been made:
Addition of 64-bit fixed-point typs -
UFP64Notes
Related Issues
Closes #37