Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strings Library #12
Strings Library #12
Changes from 47 commits
c1f05ee
1dbabcc
8a24ca7
80471e3
2838a0d
de3d3bf
4b338c7
e16aeb9
6caec29
b109dfb
e3ab49c
352c997
2830e6b
cf8608f
f3f195b
3888a91
eafb587
d7bf98d
c37c295
0529954
5033649
b2089bf
83ce059
54406dc
ab7f0a1
31dfbeb
bd7f72d
11ea781
73c397b
3c9df9f
2db5115
2863cd5
d003e41
63880ab
00a417b
83b5602
eb02cc9
68afba3
e128a7f
d3b5006
0080b06
33a00f7
b7e61fd
7db8761
ae7a296
89d06d6
c79457c
446f6a7
ab46610
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a str cannot be iterated over than I would agree with this note as Braqzen has noted as well. Did you mean perhaps to say an str cannot be casted to a String? IMO you should be able to do
let s1: String = String::from("this is an str");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this will be possible until type constraints are implemented. I think that is part of the declaration engine which afaik @emilyaherbert and @tritao are working on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good comment, this clears up a lot of the confusion I was having with the lib