fix: Fix panic in fuelup download #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Realized that nightly macos x86 builds are failing and missing from nightly entries https://github.com/FuelLabs/fuelup/blob/gh-pages/channel-fuel-nightly.toml, so anyone using nightly channel from x86 mac os should have an issue but this will be makin sure that we have a nice error!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #634
The problem is that BTreeMap index accession with
[]doesn't return a result or option, it just panics if it's not there.It would be good to have a lint to require us to use
get()instead of index access, to avoid panics like this: #636