Alter use of the --verbose flag for fuelup check

[JoshuaBatty]

The output of fuelup check --verbose is what I would expect fuelup check to output. Before this change, fuelup check outputted a fraction of the installed components on the system. I feel like this just leads to confusion amongst users so it's been removed.

I added the -v flag back in. The default behaviour is to only show fuelup or components need updating. The -v flag shows all components and prints that they are up to date. See screen shot below.

The rest of the diff is just cleaning up imports and doing clippy.

closes #553

[sdankel]

I agree that we shouldn't need a verbose flag for fuelup check, but I also think we should condense its output. I think it should show 1 line per installed toolchain when there is nothing to update, rather than showing every plugin in the toolchain, similar to rustup.

When there is an update available, it could show just the plugins that need updating. What do you think?

Currently it prints a download bar even when everything is up to date. On that note, check should never download anything, it should only tell the user if something can be updated, so that's a bug.

[JoshuaBatty]

Thanks Sophie. I like the idea of mimicking what cargo check does here. I'll also look into avoiding need to download anything for this check. Putting into draft mode until this is finished.

[JoshuaBatty]

Thanks @sdankel this should be ready now. I added the -v flag back in so it prints if the component of fuelup is up to date, but the default behaviour is now similar to rustup and only shows if something is out of date.

I also removed the download bar. We still need to download the toml file from git to check the versions but it's only a handful of kb so showing a download bar seems unnecessary.

[sdankel]

Looking much better! One thing I noticed is when I have 1 toolchain that needs updates and 1 that is up to date, the formatting for the up-to-date one is off, and doesn't say up-to-date:

[JoshuaBatty]

Thanks @sdankel i've updated the description with a screenshot of what the default and verbose options produce.

[kayagokalp]

Looks great to me!

[fuel-service-user]

LCOV of commit 9bde78c during CI #2025

Summary coverage rate:
  lines......: 81.9% (2315 of 2827 lines)
  functions..: 44.4% (363 of 818 functions)
  branches...: 58.6% (278 of 474 branches)

Files changed coverage rate: n/a

[sdankel]

LGTM 🚀