Skip to content

Conversation

DefiCake
Copy link
Member

Summary

ContractFactory.createTransactionRequest allows to pass configurableConstants, but does not use them. It is both confusing because the default ones will be used, and because the returned contract ID will not match with the one returned by the deploy method, which uses the configurables.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@DefiCake DefiCake force-pushed the df/fix/use-configurables-create-transaction-request branch from 54a1bda to 9b4b0fc Compare August 30, 2025 19:35
Copy link
Contributor

github-actions bot commented Aug 30, 2025

Temporary PR

This PR is published in AWS CodeArtifact with version: next

Install using the below commands — create-fuels variations are commented out.

PNPM

pnpm config set registry https://npm-packages.fuel.network/ --global
pnpm install fuels@next
# pnpm create fuels@next

NPM

npm --registry=https://npm-packages.fuel.network/ install fuels@next
# npm --registry=https://npm-packages.fuel.network/ create fuels@next

Bun

npm_config_registry=https://npm-packages.fuel.network/ bun install fuels@next
# npm_config_registry=https://npm-packages.fuel.network/ bun create fuels@next

luizstacio
luizstacio previously approved these changes Aug 31, 2025
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.2%(-0.01%) 69.68%(-0.01%) 76.27%(+0%) 77.23%(-0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/contract/src/contract-factory.ts 32.86%
(+0.24%)
29.5%
(+0.69%)
30.76%
(+0%)
31.97%
(+0.25%)

@luizstacio luizstacio changed the title fix: use configurables in ContractFactory.createTransactionRequest fix: configurables constants on createTransactionRequest not been set Aug 31, 2025
@DefiCake DefiCake requested a review from luizstacio September 1, 2025 11:00
@luizstacio luizstacio merged commit 25bb824 into master Sep 2, 2025
27 of 28 checks passed
@luizstacio luizstacio deleted the df/fix/use-configurables-create-transaction-request branch September 2, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants