-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typegen and storage slots integration #3396
Open
nedsalk
wants to merge
7
commits into
master
Choose a base branch
from
ns/fix/typegen-storage-slot-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+145
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
nedsalk
force-pushed
the
ns/fix/typegen-storage-slot-integration
branch
from
November 14, 2024 12:45
9fc3047
to
bd8f764
Compare
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
petertonysmith94 and
maschad
as code owners
November 14, 2024 12:46
CodSpeed Performance ReportMerging #3396 will not alter performanceComparing Summary
|
This reverts commit 7cb0db6.
nedsalk
force-pushed
the
ns/fix/typegen-storage-slot-integration
branch
from
November 15, 2024 09:01
139be6d
to
e7d6196
Compare
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes integration of typegen'd storage slots with the
ContractFactory.deployAsCreateTx
andContractFactory.deployAsBlobTx
methods by making it possible to specifydeployOptions
in theContractFactory
constructor, passing the storage slots via the constructor in typegen'd factories, and using them in those methods.This approach also enables us to remove the override of the
deploy
method in typegen.Checklist