-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added method to duplicate predicate #3395
base: master
Are you sure you want to change the base?
chore: added method to duplicate predicate #3395
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@YaTut1901 is attempting to deploy a commit to the Fuel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Hi @YaTut1901, Great work on this! We really appreciate your help. Could you edit the PR description, specifically this part:
and change it to:
Thank you! |
provider: this.provider, | ||
data: params.data ?? this.predicateData, | ||
configurableConstants: params.configurableConstants, | ||
loaderBytecode: this.loaderBytecode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loaderBytecode: this.loaderBytecode, |
The loaderBytecode
is no longer a field on the Predicate
class (after #3389).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we check the data
+ configurableConstants
have been set initially (on the first Predicate
instantiation) and then set again after using toNewInstance
?
Closes #3392
Summary
Added method
toNewInstance
which returns new instance of predicate with same abi, loaderBytecode, provider and different configurableConstants and data to be passed:Checklist