-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: handle create fuels
template scenarios for insufficient funds
#2798
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
create fuels
example dapp scenarios for insufficient fundscreate fuels
template scenarios for insufficient funds
…:fuellabs/fuels-ts into dp/chore-create-fuels-insufficient-funds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, comments inline
…:fuellabs/fuels-ts into dp/chore-create-fuels-insufficient-funds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can directly link them to the faucet, otherwise, should we decided to move the Top-up from the top right hand corner, we will have to update all these toast messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
Coverage Report:
Changed Files:
|
create fuels
example dApp scenarios for insufficient funds #2463Summary
This PR adds missing
try-catch
statements in some places where error handling is needed in case of insufficient funds in a wallet.Checklist
tests
to prove my changesdocs