Update to latest fuel-core and fuel-vm #1670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI is failing because the |
JoshuaBatty
approved these changes
Jun 12, 2025
zees-dev
added a commit
to FuelLabs/forc-wallet
that referenced
this pull request
Jun 12, 2025
Note: Requires merging of FuelLabs/fuels-rs#1670 ^ then a release is required - after which we can then update the `fuels-rs` dependency ^ this PR has been developed by locally pointing `fuels-rs` to PR branch above ## Description This pull request introduces several updates to modernize the codebase, simplify address handling, and improve maintainability. Key changes include upgrading the Rust version and edition, removing support for `Bech32` addresses, and refactoring related logic and tests to use the `Address` type consistently. - primary changes to Bech32 address removal are due to this pr: FuelLabs/fuels-rs#1669 ### Environment and Configuration Updates: * Updated the Rust version to `1.85.0` in `.github/workflows/ci.yml` and `rust-toolchain.toml` to ensure compatibility with the latest features. [[1]](diffhunk://#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL15-R15) [[2]](diffhunk://#diff-2b1bde2cf3a858b7bf7424cb8bcbf01f35b94dc80b925d9432cbab3319ca9b4eL3-R3) * Changed the Rust edition to `2024` in `Cargo.toml` for access to new language features. ### Address Handling Simplifications: * Removed support for Bech32 addresses and replaced all instances with the `Address` type across the codebase, including CLI commands, caching, and transfer logic. [[1]](diffhunk://#diff-24f1b99fe644657495a289a0eacb2189c4aa3d51dd1f39253c667c424ba4ca96L101-R94) [[2]](diffhunk://#diff-24f1b99fe644657495a289a0eacb2189c4aa3d51dd1f39253c667c424ba4ca96L215-L221) [[3]](diffhunk://#diff-24f1b99fe644657495a289a0eacb2189c4aa3d51dd1f39253c667c424ba4ca96L528-R450) * Eliminated the `To` enum and related parsing logic for Bech32 and hex addresses, simplifying address validation and usage. ### Code Refactoring: * Refactored functions to remove unnecessary conversions between Bech32 and `Address` types, reducing complexity in methods like `print_accounts_cli`, `transfer_cli`, and `verify_address_and_update_cache`. [[1]](diffhunk://#diff-24f1b99fe644657495a289a0eacb2189c4aa3d51dd1f39253c667c424ba4ca96L304-R255) [[2]](diffhunk://#diff-24f1b99fe644657495a289a0eacb2189c4aa3d51dd1f39253c667c424ba4ca96L528-R450) [[3]](diffhunk://#diff-24f1b99fe644657495a289a0eacb2189c4aa3d51dd1f39253c667c424ba4ca96L612-R518) * Updated test cases to align with the new `Address` type, removing Bech32-related assertions and ensuring compatibility with hex-based addresses. [[1]](diffhunk://#diff-24f1b99fe644657495a289a0eacb2189c4aa3d51dd1f39253c667c424ba4ca96L679-R589) [[2]](diffhunk://#diff-24f1b99fe644657495a289a0eacb2189c4aa3d51dd1f39253c667c424ba4ca96L701-R611) ### Dependency and Import Cleanup: * Reorganized imports in `src/account.rs` and `src/balance.rs` to remove unused dependencies and improve readability. [[1]](diffhunk://#diff-24f1b99fe644657495a289a0eacb2189c4aa3d51dd1f39253c667c424ba4ca96L6-L27) [[2]](diffhunk://#diff-01340666501d0dc6f96a6ea7a2d24d1d17a0ae1e499ca3cf32d2615a454353ceR2-R14) ### Documentation Adjustments: * Updated comments and type aliases to reflect the transition from Bech32 to `Address`, ensuring clarity in the codebase. --------- Co-authored-by: z <zees-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates fuel-vm and fuel-core to latest versions.
Breaking Changes
Balances are now represented as u128.
Checklist