Deny clippy::arithmetic_side_effects for fuel-merkle #729
Conversation
|
|
||
| impl<T> ComparablePath for T |
There was a problem hiding this comment.
Merged into Path trait, as they were not used separately.
|
|
||
| pub enum Instruction { |
There was a problem hiding this comment.
Renamed to Side, and used in more places
| @@ -1,50 +1,32 @@ | |||
| #[derive(Debug, Eq, PartialEq)] | |||
| pub enum Bit { | |||
There was a problem hiding this comment.
Replaced with bool or Side enum, depending on which made sense.
| trait GetBit { | ||
| fn get_bit(&self, bit_index: u32) -> Option<Bit>; | ||
| } |
There was a problem hiding this comment.
This was used only once, below. I just inlined it.
Co-authored-by: Brandon Vrooman <brandon.vrooman@fuel.sh>
Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
fuel-merkle/src/common/subtree.rs
Outdated
There was a problem hiding this comment.
The Subtree was just a hand-rolled non-empty linked list. It was always used wrapped in an option, so the use was exactly equivalent to a linked list. I first replaced it with alloc::collections::LinkedList but why not use a normal Vec instead? Actually MerkleRootCalculator already does that, so I just replaces all Subtree instances with it.
| .checked_sub(1) | ||
| .expect("Path to a tree without leaves"), | ||
| ) | ||
| .unwrap(), |
There was a problem hiding this comment.
I think we can't guaranty that this will not fail. Is someone provides invalid leaves_count, it will fail
There was a problem hiding this comment.
If the tree has a root, then leaves_count will be at least 1. In real use cases, this should be okay. But if someone were to provide arguments that are inconsistent with a real tree, this could fail. I don't think that's an issue.
Closes #170
Denies the following lints:
clippy::arithmetic_side_effectsclippy::cast_sign_lossclippy::cast_possible_truncationclippy::cast_possible_wrapChecklist
Before requesting review