Tests for Safe Arithmetic Checks in crypto.rs #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit applies safe arithmetic to call and crypto interpreter modules. The deprecated implementation of secp256k1 was not using safe arithmetic. Instead of updating it, the module was deprecated in favor of fuel-crypto.
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
ghost
requested review from
Voxelot,
Dentosal,
vlopes11,
leviathanbeak and
xgreenx
ghost
self-assigned this
ghost
changed the title
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh> # Conflicts: # src/error.rs
…ation Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh> # Conflicts: # tests/crypto.rs
ghost
marked this pull request as ready for review
vlopes11
approved these changes
Sep 27, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues work of #170
Must not be merged until after #203