Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (fuel-indexer,fuel-indexer-types): Re-integrate block producer #430

Merged
merged 3 commits into from
Dec 20, 2022
Merged

fix (fuel-indexer,fuel-indexer-types): Re-integrate block producer #430

merged 3 commits into from
Dec 20, 2022

Conversation

deekerno
Copy link
Contributor

@deekerno deekerno commented Dec 19, 2022 •
edited
Loading

Closes #334.

Changelog

  • Re-integrates block producer into BlockData

Notes

Since #421 is blocked by the proverbial dependency hell, I elected to do this in its own PR to move things forward.

Testing Plan

  1. Run test components.
  2. Start indexer service with block explorer example.
  3. Generate blocks for test data.
  4. Confirm that producer is present when adding values to database.

@deekerno deekerno self-assigned this Dec 19, 2022
@deekerno deekerno force-pushed the deekerno/add-producer-to-block branch from e4955f8 to f1a0e24 Compare December 19, 2022 19:13
@deekerno deekerno requested a review from ra0x3 December 19, 2022 20:01
@deekerno deekerno marked this pull request as ready for review December 19, 2022 20:01
@deekerno deekerno enabled auto-merge (squash) December 19, 2022 20:07
ra0x3
ra0x3 suggested changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@ra0x3 ra0x3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small code nits but otherwise looks good 👌

examples/block-explorer/explorer-index/src/lib.rs Outdated Show resolved Hide resolved
packages/fuel-indexer/src/service.rs Outdated Show resolved Hide resolved
@deekerno deekerno force-pushed the deekerno/add-producer-to-block branch from 7e616bb to f9aaaef Compare December 20, 2022 17:45
@deekerno deekerno requested a review from ra0x3 December 20, 2022 18:12
@deekerno deekerno merged commit 4711583 into master Dec 20, 2022
@deekerno deekerno deleted the deekerno/add-producer-to-block branch December 20, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ra0x3 ra0x3 ra0x3 approved these changes

Assignees

@deekerno deekerno

Labels
None yet
Projects
Fuel Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-integrate block producer into block-explorer example
2 participants
@deekerno @ra0x3