Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add native execution #425

Merged
merged 2 commits into from
Dec 19, 2022
Merged

feat: add native execution #425

merged 2 commits into from
Dec 19, 2022

Conversation

ra0x3
Copy link
Contributor

@ra0x3 ra0x3 commented Dec 15, 2022

For more context be sure to read over #389

Description

  • PR does a few things:
    • Adds support for native execution
    • Cleans up the API (swapping expect and panic for ?)
    • Adds a hello-world-native example
      • Is the exact same as the hello-world example, but with native execution
    • Integrates native execution into the forc index plugin (e.g., forc index new my-index --native)
    • Updates stop index functionality to remove indices from the database as well
    • Adds some convenience index utility functions (e.g., bytes32_from_inputs)
      • Users on Discord have complained that transforming types is a PITA so that's what these functions are for
      • In the future we might break these out into a separate crate or something

Testing steps

  • CI should pass
  • Pull down the hello-index-native example and:
    • Run a fuel node cargo run --bin fuel-node
    • Run the example cargo run --bin hello-index-native -- --manifest examples/hello-world-native/hello_index_native.manifest.yaml
    • Trigger an event cargo run --bin hello-bin
    • Event should be indexed
  • Other functionality should be unaffected
    • Should be able to upload/deploy indices
    • Should be able to stop indices

@ra0x3 ra0x3 self-assigned this Dec 15, 2022
@ra0x3 ra0x3 linked an issue Dec 15, 2022 that may be closed by this pull request
@ra0x3 ra0x3 force-pushed the rashad/feature/native-execution-3 branch from 841acd5 to 680d75d Compare December 16, 2022 16:23
@ra0x3 ra0x3 force-pushed the rashad/feature/native-execution-3 branch from ac1c6e5 to 94b924a Compare December 16, 2022 20:48
Copy link
Contributor

@deekerno deekerno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see what kind of stuff this opens up.

@ra0x3 ra0x3 merged commit 93f1d4c into master Dec 19, 2022
@ra0x3 ra0x3 deleted the rashad/feature/native-execution-3 branch December 19, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feature: native execution
2 participants