Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forc index stop #413

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Add forc index stop #413

merged 3 commits into from
Dec 9, 2022

Conversation

deekerno
Copy link
Contributor

@deekerno deekerno commented Dec 8, 2022 •
edited
Loading

Closes #396.

Changelog

  • Add forc index stop command
  • Move extract_manifest_fields to utils
  • Clean up docstrings for other commands

Testing Steps

  1. cargo build --release -p forc-index
  2. cp target/release/forc-index ~/.fuelup/bin
  3. Start an index and verify that it indexes data
  4. forc index stop --manifest [same_manifest_as_running_index] --auth foo
  5. Logging should say that index has been stopped.
  6. Verify that indexer no longer indexes data.

@deekerno deekerno self-assigned this Dec 8, 2022
@deekerno deekerno added the plugin label Dec 8, 2022
@deekerno deekerno force-pushed the deekerno/396-add-forc-index-stop branch from d335ecc to 60b2201 Compare December 8, 2022 18:33
@deekerno deekerno marked this pull request as ready for review December 8, 2022 19:05
@deekerno deekerno requested a review from ra0x3 December 8, 2022 19:05
ra0x3
ra0x3 suggested changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@ra0x3 ra0x3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small pieces of feedback that aren't make or break

  • Using fuel_indexer_lib for some utility stuff
  • Additional info in the logs (so it's extremely clear to the user what's going on)

Looks good 👌

plugins/forc-index/src/ops/forc_index_stop.rs Outdated Show resolved Hide resolved
plugins/forc-index/src/ops/forc_index_stop.rs Outdated Show resolved Hide resolved
plugins/forc-index/src/utils/mod.rs Show resolved Hide resolved
@deekerno deekerno force-pushed the deekerno/396-add-forc-index-stop branch from 60b2201 to 01c7730 Compare December 8, 2022 22:05
@deekerno deekerno enabled auto-merge (squash) December 8, 2022 22:12
@deekerno deekerno requested a review from ra0x3 December 8, 2022 22:36
@deekerno deekerno merged commit 1d0bfb5 into master Dec 9, 2022
@deekerno deekerno deleted the deekerno/396-add-forc-index-stop branch December 9, 2022 03:11
ra0x3 pushed a commit that referenced this pull request Dec 15, 2022
@deekerno
Add forc index stop (#413)
837ec07 
* Add forc index stop command

* Clean up other forc index commands

* Address ra0x3 feedback
@ra0x3 ra0x3 mentioned this pull request Dec 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ra0x3 ra0x3 ra0x3 approved these changes

Assignees

@deekerno deekerno

Labels
None yet
Projects
Fuel Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add forc index stop command
2 participants
@deekerno @ra0x3