Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hello world example #360

Merged
merged 10 commits into from
Nov 30, 2022
Merged

Add hello world example #360

merged 10 commits into from
Nov 30, 2022

Conversation

ra0x3
Copy link
Contributor

@ra0x3 ra0x3 commented Nov 25, 2022 •
edited
Loading

Description

  • PR does a few things:
    • Adds a "Hello world" type of example that demonstrates pretty much all the indexer can do at the moment, in a easy-to-understand way
      • Updates the Quickstart example accordingly
    • Adds a String255 schema type (similar to Django CharField type)
    • Indexes executors in the service according to {namespace}.{identifier} instead of just {namespace}

Testing steps

@ra0x3 ra0x3 added documentation Improvements or additions to documentation book labels Nov 25, 2022
@ra0x3 ra0x3 self-assigned this Nov 25, 2022
@ra0x3 ra0x3 marked this pull request as draft November 25, 2022 20:30
@ra0x3 ra0x3 force-pushed the rashad/add-hello-world-example-1 branch from 8733e9c to 0467563 Compare November 28, 2022 02:13
@ra0x3 ra0x3 added the blocked This change is currently blocked by a linked issue label Nov 28, 2022
@ra0x3 ra0x3 force-pushed the rashad/add-hello-world-example-1 branch from 94b9c97 to 707a556 Compare November 29, 2022 17:11
@ra0x3 ra0x3 force-pushed the rashad/add-hello-world-example-1 branch from e240c75 to dfa4877 Compare November 30, 2022 15:57
@ra0x3 ra0x3 added enhancement and removed blocked This change is currently blocked by a linked issue labels Nov 30, 2022
@ra0x3 ra0x3 marked this pull request as ready for review November 30, 2022 16:11
@ra0x3 ra0x3 requested a review from deekerno November 30, 2022 16:25
@ra0x3 ra0x3 requested review from deekerno and removed request for deekerno November 30, 2022 18:43
deekerno
deekerno approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@deekerno deekerno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just some non-blocking nits. Thanks for doing this!

docs/src/examples/hello-world.md
let greeter_id = u64_id(&event.person.name.to_string());

// Here we 'get or create' a Salutation based on the ID of the event
// emiited in the LogData receipt of our smart contract
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "emitted"

examples/hello-world/hello-index/src/lib.rs
let greeter_id = u64_id(&event.person.name.to_string());

// Here we 'get or create' a Salutation based on the ID of the event
// emiited in the LogData receipt of our smart contract
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as other comment; "emitted".

packages/fuel-indexer-plugin/Cargo.toml
@@ -10,6 +10,7 @@ description = "Fuel Indexer Plugin"
crate-type = ['rlib']

[dependencies]
# fuels = { version = "0.30" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this here?

@ra0x3 ra0x3 merged commit 0d406b9 into master Nov 30, 2022
@ra0x3 ra0x3 deleted the rashad/add-hello-world-example-1 branch November 30, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deekerno deekerno deekerno approved these changes

Assignees

@ra0x3 ra0x3

Labels
documentation Improvements or additions to documentation
Projects
Fuel Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ra0x3 @deekerno