Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove native execution #1423

Merged
merged 3 commits into from
Oct 24, 2023
Merged

chore: remove native execution #1423

merged 3 commits into from
Oct 24, 2023

Conversation

ra0x3
Copy link
Contributor

@ra0x3 ra0x3 commented Oct 19, 2023 •
edited
Loading

Thanks for opening a PR with the Fuel Indexer project. Please review the Checklist below and ensure you've completed all of the necessary steps to make this PR review as painless as possible.

Checklist

  • Ensure your top-level commit message is in line with our contributor guidelines.
  • Please add proper labels.
  • If there is an issue associated with this PR, please link the issue (right-hand sidebar)
  • If there is not an issue associated with this PR, add this PR to the "Fuel Indexer" project (right-hand sidebar)
  • Please allow Codeowners at least 24 hours to do a first-pass review.
  • Please add thoroughly detailed testing steps below.
  • Please keep your Changelog message short and sweet.

Description

PR removes all references to native execution - from docs, and from the codebase

Testing steps

  • CI should pass

Changelog

  • chore: remove native execution

@ra0x3 ra0x3 self-assigned this Oct 19, 2023
@ra0x3 ra0x3 linked an issue Oct 19, 2023 that may be closed by this pull request
Remove native execution #1420
Closed
@ra0x3 ra0x3 marked this pull request as ready for review October 23, 2023 18:01
@ra0x3 ra0x3 added the breaking This is a change that will break some component of the project once merged to origin/develop label Oct 23, 2023
deekerno
deekerno approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@deekerno deekerno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪦

lostman
lostman approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@lostman lostman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 📿

@lostman lostman merged commit e74272b into develop Oct 24, 2023
19 checks passed
@lostman lostman deleted the rashad/1420-remove-native-exec branch October 24, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostman lostman lostman approved these changes

@deekerno deekerno deekerno approved these changes

Assignees

@ra0x3 ra0x3

Labels
breaking This is a change that will break some component of the project once merged to origin/develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove native execution
3 participants
@ra0x3 @lostman @deekerno