Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve --embedded-database messaging #1407

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

ra0x3
Copy link
Contributor

@ra0x3 ra0x3 commented Oct 11, 2023

Thanks for opening a PR with the Fuel Indexer project. Please review the Checklist below and ensure you've completed all of the necessary steps to make this PR review as painless as possible.

Checklist

  • Ensure your top-level commit message is in line with our contributor guidelines.
  • Please add proper labels.
  • If there is an issue associated with this PR, please link the issue (right-hand sidebar)
  • If there is not an issue associated with this PR, add this PR to the "Fuel Indexer" project (right-hand sidebar)
  • Please allow Codeowners at least 24 hours to do a first-pass review.
  • Please add thoroughly detailed testing steps below.
  • Please keep your Changelog message short and sweet.

Description

  • This PR does not detect auto-failure of --embedded-database - that would be pretty hard to do. But it does improve messaging when using --embedded-database

Testing steps

  • Update forc index start with local binary path let mut cmd = Command::new("./target/release/fuel-indexer");
  • Build binaries locally cargo build -p forc-index -p fuel-indexer -p fuel-indexer-api-server --release --locked
  • Run forc index cargo run --bin forc-index -- start --embedded-database --run-migrations --verbose
  • Should see more informative messaging related to --embedded-database flag

Changelog

  • chore: improve --embedded-database messaging

@ra0x3 ra0x3 self-assigned this Oct 11, 2023
@ra0x3 ra0x3 linked an issue Oct 11, 2023 that may be closed by this pull request
@ra0x3 ra0x3 changed the title chore: improve embedded db messaging chore: improve --embedded-database messaging Oct 11, 2023
@ra0x3 ra0x3 marked this pull request as ready for review October 11, 2023 15:27
Copy link
Contributor

@deekerno deekerno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ra0x3 ra0x3 merged commit 8ba2936 into develop Oct 14, 2023
19 checks passed
@ra0x3 ra0x3 deleted the rashad/1037-improve-embedded-db-messaging branch October 14, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the error message when --embedded-database fails to start
3 participants